Updates for logging under Java 21 #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrobin
reviewed
Sep 25, 2025
alexrobin
reviewed
Oct 10, 2025
Member
|
The migration to logback 1.5.13 caused all log statements from the module loggers to be missing for me. Did you notice that too? I'm going to try to fix it quickly but otherwise I will have to revert the change for now |
Member
|
It took me a while to figure it out but I pushed a fix for this, see 0c56710 |
Collaborator
Author
|
I am sorry I did not catch that. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Java 21 the StaticLogger is no longer available so the dependencies needed updating and the logic to create loggers had to change to resolve a registered logger implementation for Log4J other than default NOP logger (no operation)